Fix class loading instrumentation#1275
Merged
tylerbenson merged 1 commit intoMar 2, 2020
Merged
Conversation
tylerbenson
approved these changes
Mar 2, 2020
Contributor
tylerbenson
left a comment
tylerbenson
left a comment
There was a problem hiding this comment.
Thanks for the update!
|
@tylerbenson is this new change integrated part of the newbuild ? |
|
@tylerbenson when will you release new jar with 1275 code ? |
Contributor
|
You can try the latest snapshot build from master here: https://oss.jfrog.org/artifactory/oss-snapshot-local/com/datadoghq/dd-java-agent/0.45.0-SNAPSHOT/dd-java-agent-0.45.0-SNAPSHOT.jar |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Need to reset CallDepthThreadLocalMap before leaving @OnMethodEnter (not waiting until @OnMethodExit).
Otherwise it will prevent the loadClass() instrumentation from being applied when loadClass() ends up calling a ClassFileTransformer which ends up calling loadClass() further down the stack (since the call depth check would then suppress the nested loadClass instrumentation). Which can lead to ClassNotFoundException/NoClassDefFoundError on the agent's bootstrap classes that should be visible to all class loaders.
Ran into this while testing on JBoss. 🙁